This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Re-escape commas when updating classes #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this makes sense, I will dive into the raws.value thing and try and remember exactly how that works but if the tests are passing then it's at least as good as it was so worth merging! Thanks man. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
When running classes through
postcss-selector-parser(inupdateAllClassesandupdateLastClasses) the classes (which we have already escaped, see #91) are re-escaped, and the commas are converted back from\2cto\,. This PR converts them back so that commas in classes containing variants are not affected by the minifier bug.I'm not sure if setting
raws.valueis the best way to do this, so open to other suggestions! Another option I considered is to runescapeCommason theresultin these functions, butresultis a full selector (e.g..something .another div) so this felt less "correct" to me.